Changes volume and length of steel resources #56870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Changes volume and length of steel resources"
Purpose of change
Most basic steel components, like chunks of steel, or sheet metal, have a volume far beyond its density. The weight should be the limiting factor when trying to store steel, not the volume.
This PR also adds more accurate lengths to sheet metal, so that they can't be stored as easily in small bags.
Describe the solution
Lumps of steel are formed, and so should be as dense as an ideal block of steel (8 g/cm3). Chunks of steel are misshapen, which I have interpreted as 4 g/cm3, and scraps are bulky, which I have interpreted as 2 g/cm3.
The excel spread sheet has the stats for small metal sheet and sheet metal, assuming 20 gauge steel (0.912 mm thick) as this is the automotive thickness, and also good for general purpose, such as in 200L tanks.
Also note that a comment in the code says that sheet metal is rolled up, so the volume for that item is slightly more.
Describe alternatives you've considered
Testing
Additional context
sheet metal sizes.xlsx