Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamps the randomized Hub 01 mercenary into a defined character #56843

Merged
merged 6 commits into from
Apr 22, 2022
Merged

Revamps the randomized Hub 01 mercenary into a defined character #56843

merged 6 commits into from
Apr 22, 2022

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Apr 16, 2022

Summary

Content "The randomized Hub 01 mercenary is now a defined character, with a new name, personality, and background"

Purpose of change

Pretty much everything in my initial PR to create Smokes can be repeated here; in addition to wanting to update the dialogue and polish out kinks, I think that consistently-appearing characters/static NPCs are much more interesting when they're genuine characters with defined personalities and behavior.

Describe the solution

The new NPC is named Cranberry Foster, because I couldn't think of anything else for the first name. They're a former park ranger with blond hair, blue eyes, and rose skin. Personality-wise, they're very laid back and a little awkward, but generally patient and always genuine.

Code changes:

  • Renamed NPC_ROBOFAC_MERC_1.json to NPC_Cranberry_Foster.json. All Git history is preserved in the new file.
  • Stats, skills, and appearance are now fixed, instead of being random. Being a park ranger, they have a wide variety of skills, as well as being quite skilled in food handling, computers, and electronics. Pretty competent survivor overall.
  • Now wears a wedding ring.
  • Now spawns with 7 protein rations, 2 bottles of clean water, 15-18 Hub 01 gold coins, a smart phone, and a first aid kit. This is all for flavor, for the most part.
  • Replaced the repeatable mission to bring 200 units of gold for 8 Hub 01 coins with a dialogue option that does the same thing, for the purpose of cleanliness and allowing players to trade easily in batch. The mission def has been moved to obsolete.json.

Dialogue changes:

  • Introduced unique dialogue when meeting the NPC for the first time.
  • Rewrote almost all existing dialogue responses to match the new personality and characterization.
  • Now features contextual responses when asking if they know anything about Hub 01.
  • Questions asking about the HWP and how to get it are removed from the dialogue options when Cranberry promises to vouch for the player in obtaining one.
  • Cranberry's gender and sex are never defined or hinted at, as their face and voice are both androgynous. Implemented a line of Cranberry teasing the player for asking, which becomes available once trust has reached a certain threshold.
  • Implemented a long, one-time dialogue chain detailing parts of Cranberry's past life and character that become available once the player has helped them with their mission or traded gold with them at least once.

Describe alternatives you've considered

Considered having the NPC spawn in as part of an EOC that triggers when the player is returning to Hub 01 after being away instead of immediately after finishing Steal a dead man's mind, to try and flesh out the sensation of things happening while they weren't there. I'm still open to this, and I might do it in this PR, but I wanted to get the meat and potatoes of the change up onto Github before I made smaller tweaks.

Writing is relative, so I'm open to suggestions.

Testing

Spawned in Hub 01 using the overmap editor and progressed the questline using spawned-in items until the NPC spawned. Walked through all of the dialogue options; verified that gold trading was working, as well as dialogue options changing or appearing as Cranberry's trust with the player grew.

Additional context

image

image

image

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 16, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • I guess I am, yeah. Feels like a stupid fetch quest." They suddenly pause. "Hey. If you happen across any gold out in the world, I'll pay you to bring it back for me. Right now my assignmnt stipulates eight scrip per set, and I'd be willing to give you all of that. I just want something else to do. Just maybe don't mention it to the intercom, alright? This is supposed to be my job.
  • With the source of the radio tower's inteference fixed, return to Hub 01 with Cranberry.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 16, 2022

CC: @John-Candlebury, since Hub 01 is kind of their thing

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 16, 2022
@Gotdamnmiracle
Copy link

This looks like something I'd like to do for the arsonist character in the refugee center. I was hoping to flesh them out a bit more, but have zero idea how.

I shot you a message on the CDDA discourse forum. Would you be able to walk me through the process?

Additionally, if you'd like to write up more NPCs I'd love to toss my hat in the ring.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 17, 2022

I haven't actually used Discourse in ages and don't have the credentials, so I wouldn't expect a response there. I'm a pretty terrible teacher, but I can refer you to the following PRs as reference material:

#56438
#56308
#52374

@Ilysen Ilysen changed the title [CR] Revamps the randomized Hub 01 mercenary into a defined character Revamps the randomized Hub 01 mercenary into a defined character Apr 21, 2022
@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 21, 2022

I haven't heard any concerns or discussion about this so far, so it should be ready for review and possibly merge (if everything seems ok).

Copy link
Member

@John-Candlebury John-Candlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@Inglonias
Copy link
Contributor

The minor spelling error I discovered during my review has not been resolved yet.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 21, 2022

What would that be? Your comment only makes a remark about what the character says in their intro text, not any kind of grammar concerns.

@Inglonias
Copy link
Contributor

What would that be? Your comment only makes a remark about what the character says in their intro text, not any kind of grammar concerns.

There was a second comment regarding line 389 of NPC_Cranberry_Foster.json. They say Uh, call be Cranberry, when it should be Uh, call me Cranberry. Sorry. Github is being weird.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 21, 2022

Good eye, thanks.

@John-Candlebury John-Candlebury merged commit 9938e06 into CleverRaven:master Apr 22, 2022
@Ilysen Ilysen deleted the merc-revamp branch April 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants