Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innawoods] Ethanol and jacks #56796

Merged
merged 6 commits into from
Apr 18, 2022
Merged

[Innawoods] Ethanol and jacks #56796

merged 6 commits into from
Apr 18, 2022

Conversation

Sathra225
Copy link
Contributor

Summary

Mods "Adds jacks, forage moonshine and a thermometer-free ethanol recipe"

Purpose of change

Jacking tool quality is now available, as is moonshine without raiding monster nests. Also adds a way to get ethanol without a thermometer, removing the issue of not being able to make a thermometer without ethanol.

Describe the solution

Gives autolearn: true to all 3 jack types. Adding a third moonshine mash recipe using cattail rhizome/dahlia root/buckwheat. Adds a second ethanol recipe that take 4 times as long (2h per recipe unit) to simulate evaporation distillation.

Describe alternatives you've considered

Learning C++ to add an evaporation distiller, or some kind of delayed transform thing that does the same result.
Adding a batch time multiplier to the second ethanol recipe to give it more use, but honestly it takes so long and who makes that much moonshine at once. Fermenting vats take a ton of work already.

Testing

Made changes, all recipes showed up. No errors.

Additional context

Ethanol can be distilled out at lower temps (~50C) than its boiling point (78C), it just takes considerably longer time. Basically, the survivor is applying just enough heat for vapour to start releasing and holding it there for a long time. Normally, it would be distilled multiple times, but the current recipe doesn't do that either so eh.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 14, 2022
@NetSysFire
Copy link
Member

Due to technical difficulties with the code owners file there was no review requested from @Light-Wave, ugh.

I am not too sure about the dahlia moonshine. Apparently cattail rhizome does work but I have no clue about dahlia. Salsify does not appear to be a candidate for this either, so I would potentially remove dahlia from this.

@Light-Wave
Copy link
Contributor

Due to technical difficulties with the code owners file there was no review requested from @Light-Wave, ugh.

I am not too sure about the dahlia moonshine. Apparently cattail rhizome does work but I have no clue about dahlia. Salsify does not appear to be a candidate for this either, so I would potentially remove dahlia from this.

Cattail and buckwheat should be enough options, so I would say either remove dahlia, or show sources that shows that it can be done. Other than that, this looks good.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 17, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 18, 2022
@dseguin dseguin merged commit 4cf25da into CleverRaven:master Apr 18, 2022
@Sathra225 Sathra225 deleted the innawoods_additions branch April 18, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants