Unifies grammar for morale types #56761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Fixed up some grammar with morale events"
Purpose of change
Inconsistent writing is always crummy, I think! A lot of these were capitalized inconsistently or had punctuation where they shouldn't.
Describe the solution
Audited all the entries in
morale_types.json
to follow standards that the rest of the game uses. There are some exceptions to grammar (for instance, traits that provide a fixed morale bonus/malus are still capitalized the same as the name of their respective traits, not including Mood Swings), but in general, they should all be grammaticized in the right places now.Also renamed
Diazepam Craving
toCraving prescription sedatives
, since DDA doesn't use trademark names for meds anymore.Describe alternatives you've considered
Anguished By Memories of Butchering a Human Corpse
feels really awkward to read, at least to me, butAnguished by memories of butchering a human a human corpse
doesn't!Testing
Spawned in a bunch of stuff using debug to test various morale types. Murdered the poor starting NPC to make sure that that one worked correctly. I didn't test all of these since they're just string changes, but if requested, I'll totally make sure that all of them work.
Additional context
N/A