Show remembered vehicles across z levels

[haveric]

Summary

Bugfixes "Show remembered vehicles across z levels"

Purpose of change

Fixes #48897

Describe the solution

Track the z-level for remembered vehicles and show the symbol for the closest z-level. Shows "^" if vehicle is above, "v" if vehicle is below, or "c" if on the current level.

Describe alternatives you've considered

None

Testing

Loaded a game. Spawned some vehicles on varying z-levels near a silo and bridge. Examined each and set "Remember vehicle position" on them. Saw symbols showing the direction of the vehicle when standing on other z-levels.

Spawned vehicles at the top and bottom of a silo. Saw the symbol change (in the minimap) from "c" at the top, "^" below that, "v" one level above the ground, and then back to "c" at the ground.

Additional context

Screenshots

Map:

Minimap:

Graphical Overmap:

[dseguin]

Tested this locally and it works as advertised. Nice work! Spoke too soon, see edit below

I see that you added support for the overmap in the sidebar, but the "custom" sidebar uses a different function for drawing the overmap:

Cataclysm-DDA/src/display.cpp

Line 1098 in 931ad4f

std::string display::colorized_overmap_text( const avatar &u, const int width, const int height )

Could you implement the same behaviour there? No problem if not, it's not a showstopper.

---

Edit: Looks like the z-level indicator only works with graphical overmap disabled:

Enabling it uses the previous behaviour:

[haveric]

I'll take another look at those when I get a chance. Moving this to draft for now.

[haveric]

@dseguin I've updated it to support both. I'm not sure how to test the custom sidebar, but it should work the same way. I also decided to move the shared functionality to a function; it was getting to be in too many places and this should prevent accidental changes to one and not the others. Let me know if they belong outside of overmapbuffer though.

Also, is there anything I need to do to notify graphical overmaps of the new names?

[dseguin]

Tested:

• Overmap, non-graphical
• Overmap, graphical
• Overmap widget, default sidebar
• Overmap widget, custom sidebar

Looks like it's all good!

---

For the future, you can swap the sidebar template to "custom" in the panel manager (} by default):

As for the new overmap tile ids, my understanding is that the tileset repo has scripts for discovering tile ids. If not, I would just post a comment in the graphics channel on Discord with the new ids just to be sure.