Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugout bags error #56743

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

    "entries": [
      { "item": "backpack", "contents-group": "small_bugout", "prob": 100 },
      { "item": "daypack", "contents-group": "small_bugout", "prob": 100 },
      { "item": "backpack_leather", "contents-group": "small_bugout", "prob": 100 }

At the moment, we don't handle things like "item too big for container" per itemgroup entrie, the game just trows an error. see link
https://discord.com/channels/598523535169945603/873624399998234675/962795682136207442

Describe the solution

Use more itemgroups to accomplish the same result

Describe alternatives you've considered

Testing

Testing the bougout_bag itemgroup, no erros
Screenshot from 2022-04-10 15-14-40

Additional context

I love itemgroups

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 10, 2022
@bombasticSlacks
Copy link
Contributor

Thanks, I ran quite a few tests on the small bags and thought they were safe after a lot of tweaking.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2022
@Maleclypse Maleclypse added the <Bugfix> This is a fix for a bug (or closes open issue) label Apr 10, 2022
@kevingranade kevingranade merged commit 2cb06a4 into CleverRaven:master Apr 11, 2022
@casswedson casswedson deleted the my-bag-man branch April 11, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants