Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to NPC classes #56708

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

@Faalagorn Faalagorn commented Apr 9, 2022

Summary

None

Purpose of change

Unify the class names and descriptions.

Describe the solution

Change the class name to title case and add full stops to descriptions to match others.

Describe alternatives you've considered

Rename "No class" to "No Class.

Testing

Not sure where it appears, I think it can be inspected on NPCs?

Additional context

Fixes some Transifex issues.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 9, 2022
@Faalagorn Faalagorn changed the title former cop → Former Cop Minor fixes to NPC classes Apr 9, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit 2b38de5 into CleverRaven:master Apr 12, 2022
@Faalagorn Faalagorn deleted the patch-11 branch April 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants