Rewrite cannabis essential oil extraction #56703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
|
Did you make sure that the old item IDs are properly obsoleted or migrated? I'm not seeing them in there, but this is large and I'm on my phone |
Yes, I did check that I've added obsoletion and migration entries to all the removed recipes and items. I don't think I've missed anything. |
|
@AtomicFox556 any chance this fixes #43453? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Make cannabis essential oil extraction less awkward to perform"
Purpose of change
Currently cannabis oil extraction is extremely awkward to do because it requires making use of tools that need to be activated to be used for crafting; they will be using up batteries during crafting time, and the craft will be interrupted if the battery if fully drained. Also, the processes make use of multiple steps as separate recipes, making this even worse.
Describe the solution
Change the recipes to no longer require active tools, and consolidate all the recipes into all the possible production chains given all the equipment that is currently available. Did some other minor consistency checks to items and recipes.
Removed a "dab pen" item; as much as I was able to figure out, it's essentially the same as electronic cigarette (or at least they could substitute each other), so it was migrated to that.
Describe alternatives you've considered
Getting rid of consumable plastic gaskets as well until there's some better way to simulate parts of machinery wearing down with use.
Making it possible to place all the machinery as appliances, but decided to not do it in this PR as it's already large.
Testing
Launched the game, made sure that no errors happen and that all the recipes work fine.
Additional context
None.