Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] nest rework #56667

Merged
merged 36 commits into from
Apr 14, 2022
Merged

[DinoMod] nest rework #56667

merged 36 commits into from
Apr 14, 2022

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Apr 8, 2022

Summary

Mods "[DinoMod] nest rework"

Purpose of change

Bugfixes, realism

Describe the solution

Applies bugfixes and improvements figured out in #56649 to all of the rest of the dino nests. Straw spawns at all nests. Dino predators have a guaranteed spawn and are on guard duty. Loot spawn and bone and feather spawns are fixed. Meat spawns at predator nests. Other dinos are on guard duty. Forest trash spawns at plant eating and bug eating nests

Describe alternatives you've considered

Figure out some kind of clever nesting mapgen thing to make this work better still

Testing

Game loads no errors, nests spawn and look right

Additional context

Based on a lot of research but especially https://www.prehistoriclife.xyz/cretaceous-period/eggs-nests-and-parental-care-in-ornithopods.html#:~:text=An%20adult%20hadrosaur%E2%80%94most%20likely,to%2020%20eggs%20per%20nest.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 8, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 8, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 9, 2022
@LyleSY LyleSY marked this pull request as ready for review April 9, 2022 23:48
@I-am-Erk I-am-Erk merged commit dd1af2f into CleverRaven:master Apr 14, 2022
@LyleSY LyleSY deleted the nest-rework branch April 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants