Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density balance: alcohol and liquid food #56664

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Density balance: alcohol and liquid food #56664

merged 3 commits into from
Apr 20, 2022

Conversation

batekulve
Copy link
Contributor

@batekulve batekulve commented Apr 8, 2022

Summary

Balance "Corrected or unified densities of liquid food consumables"

Purpose of change

#54811 Fix incorrect densities of liquid foods.

Describe the solution

Sometimes this is correcting a weight that is too high or too low. Sometimes it's bringing similar foods more in line with each other. For example, evaporated milk should not weigh more than milk.

Describe alternatives you've considered

I went back and forth on whether I should change weights that are just a little bit off, but mostly decided not to touch it when it's close. I'm not sure why some of these very specific numbers (down to the mg) were used but there might have been a good reason.

Testing

Copied changed json files to the latest experimental version. Checked item spawning menu to make sure the items are the correct weight.

Additional context

Corrected or unified densities of liquid food consumables
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 8, 2022
@batekulve
Copy link
Contributor Author

I realize I made a mistake, evaporated milk should be heavier than milk. If you remove some of the water, what's left is a higher proportion of heavier-than-water ingredients. I'll change it this evening.

Fixed density of evaporated milk. Made syrup densities consistent.
@Maleclypse
Copy link
Member

Are you ready for merging? I noticed you have todo listed on your testing.

must, mash, wort, and wash should not weigh less than the products they ferment into
@batekulve
Copy link
Contributor Author

@Maleclypse During testing I noticed some weights of brewing products were still incorrect. Those look good now. Tested and ready for merging.

@kevingranade kevingranade merged commit a2b1847 into CleverRaven:master Apr 20, 2022
@RandDenner
Copy link
Contributor

RandDenner commented Apr 20, 2022

Sorry to necro, but I only just read this and I have a question.

I realize I made a mistake, evaporated milk should be heavier than milk.

I assume you mean if the volume is the same, evaporated milk should be heavier than milk?

If you simply take, say, a liter of milk and remove some or all of the water, then the weight would go down.

However, if you evaporate, say, 3 liters of milk to get 1 liter of evaporated milk (or however many starting liters are required to result in one liter of product), then as the density of the end product material is greater, the weight would be greater as well.

@batekulve
Copy link
Contributor Author

Yes, heavier per ml than milk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants