Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden books #56647

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Harden books #56647

merged 5 commits into from
Jan 9, 2023

Conversation

BoatNectar
Copy link
Contributor

@BoatNectar BoatNectar commented Apr 7, 2022

Summary

Bugfixes "Add hardcovers/binders to books where appropriate"

Purpose of change

Fixes #55166
Many books in the game are technically paperback and are treated as a pliable stack of papers that can be (presumably) rolled up and fit into any container given enough volume. Many of the books treated this way have descriptions that conflict with this behavior. A "thick hardbound copy" of a book or a field manual (presumably in a plastic ring binder) should not be treated the same as a glossy magazine or small handbook.

Describe the solution

I've added a cardboard material to many books that are likely to be or explicitly described as hardcovers. I've also added the plastic tag to things likely to be in plastic ring binders such as larger collections of lab notes and military field manuals. I have taken some liberty in adding the cardboard material to books described as being thick or exhaustive despite not being able to affirm whether or not they would be hardcopies as it has the intended effect of limiting the pliability of the book without doing so in a way that doesn't make sense to the player.

Describe alternatives you've considered

Change the way that the paper material is handled when storing items in containers so that large paper items (such as textbooks) are treated differently from small, pliable handbooks and notes based on volume or weight.

The particular items that I've chosen to add the cardboard tag to were based on my own intuition, and the associated item descriptions. I'm open to any feedback regarding these changes.

Testing

Spawned one of the affected books, tried [i]nserting it into a water bottle and could no longer do so.

Additional context

My search history is really suspicious at the moment.

Adjusts materials for books and manuals based on descriptive text
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Apr 7, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 7, 2022
@BoatNectar BoatNectar marked this pull request as draft April 7, 2022 11:59
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 7, 2022
@batekulve
Copy link
Contributor

In my experience driving handbooks are typically cheaply made paperbacks to allow for writing in worksheets and practice tests.
https://www.amazon.com/Driving-Book/s?k=Driving+Book All of these are only offered in paperbacks.

"Antique Adornments" is half the weight of the books listed above it, despite being the same volume. I don't know how much stock you're putting on the in-game weights, but this seems to indicate a paperback.
Same situation with the several armorsmithing textbooks, though I'm more inclined to believe these just have too low a weight.

@github-actions github-actions bot added Melee Melee weapons, tactics, techniques, reach attack and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 25, 2022
@Maleclypse Maleclypse marked this pull request as ready for review January 8, 2023 16:00
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Jan 9, 2023
@dseguin dseguin merged commit 9961900 into CleverRaven:master Jan 9, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some books fit inside plastic Bottles
5 participants