Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural forms to missing armors #56635

Merged
merged 8 commits into from
Apr 9, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Add missing plurals for a few gauntlets, vambraces and greaves.

Describe the solution

Replace str_sp with proper str and str_sp combination including pairs of variants, since all take pair of limbs.

Describe alternatives you've considered

None.

Testing

Compiled the game, observed proper plural forms for affected items.
screenshot_2022-04-07-002859

Additional context

Fixes some Transifex issues.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 6, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 7, 2022
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod labels Apr 7, 2022
@Faalagorn Faalagorn requested a review from KorGgenT as a code owner April 7, 2022 18:33
@github-actions github-actions bot added the Mods: Magiclysm Anything to do with the Magiclysm mod label Apr 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • XL galeae
  • XL kabutos
  • XS galeae
  • XS kabutos

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@kevingranade kevingranade merged commit 3aeefb8 into CleverRaven:master Apr 9, 2022
@Faalagorn Faalagorn deleted the plural-armor branch April 9, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants