Restore details of byproducts/container contents to the crafting gui #56632
Conversation
This information was originally added to the crafting gui in PR#51496. However, a subsequent unrelated change removed the lines that actually displayed it.
github-actions
bot
added
[C++]
|
Thanks for fixing this! I think the lines were reverted during a rebase or something. Totally my mistake :P |
|
Double "Result" line just doesn't look that good |
github-actions
bot
added
the
BasicBuildPassed
Other formats can be arranged, but that was the only one that was discussed in the previous Issue/PR. I've also been experimenting with this alternative: Whatever the formatting ends up looking like, I think it needs to:
|
Recipes with multiple byproducts (e.g. heavy cream) only had one
"Byproduct" header. Adding a header for each iteminfo section allows
the user to more easily find the details they're looking for.
Several strings that needed to be translated were not being flagged
with _(), and several strings that did not need to be translated (e.g.
_("<bold>") were being flagged for translation.
With the new formatting, this function, which was a wrapper for readability around adding to an std::vector<iteminfo>, was no longer used or useful.
github-actions
bot
removed
the
BasicBuildPassed
|
The last three commits lay out the alternative format I mentioned above: I also did some testing in German with placeholder translations to see if I was flagging things correctly. Turns out I wasn't. The original PR had bold tags flagged for translation, but not "Byproduct". I think I've resolved that now (Note: the placeholder translations below are not included in this PR, and are probably wrong): |
github-actions
bot
added
the
BasicBuildPassed
Summary
Interface "Restore details of byproducts and container contents to the crafting UI"
Purpose of change
Pull request #51496 added display of information on byproducts and details of items in containers to the results pane of the crafting GUI. However, a subsequent PR working on a different part of the crafting UI (#52685) overwrote the line that actually displayed this information. Since most of the required code is still present and issue #56279 suggests that this is still an area of confusion for players, it makes sense to restore this functionality.
Describe the solution
See #51496 for full discussion of implementation.
Describe alternatives you've considered
See #51496 for discussion of alternatives.
Testing
Tested display of the results pane in a variety of window sizes on a computer monitor.
Did not test with any other physical screen size.
Did not test in any language other than English.
Also tested jumping to an item's recipe to ensure that the relevant code removed was not key to #52685.
Additional context
Appearance of items with no container/byproducts:
Appearance of items with byproducts in addition to the primary result:
Appearance of items with results in containers:
Appearance of items with byproducts and primary results in containers:
Appearance of batch crafting:
