Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bionic removal chance from Rubik/doctors #56558

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Improve bionic removal chance from Rubik/doctors #56558

merged 1 commit into from
Apr 6, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Apr 3, 2022 •
edited
Loading

Summary

Bugfixes "Improve bionic removal chance from Rubik/doctors"

Purpose of change

Fixes #56554. Fixes #55292

Describe the solution

Set the removal skill to the same as the installation skill, which is 20.

Describe alternatives you've considered

  • Allow dialogue to set the specific skill, so that exodii can have a higher skill than the Tacoma doctor (I may still implement this later, but it's probably not needed for now)
  • Increase the skill for both installation and removal

Testing

Started as a Failed Cyborg. Spawned in the Exodii base. Completed Rubik's missions until accessing Bionic installation/removal. Removed the bad CBMs and see much more reasonable fail chances.

Additional context

Removing Acidic Leaking CBM:
image

Removing Faulty Electric System:
image

Removing Electrical Drain:
image

Removing Noisemaker:
image

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 3, 2022
@kevingranade kevingranade merged commit cdeabce into CleverRaven:master Apr 6, 2022
@haveric haveric deleted the bionic-uninstall branch April 6, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
2 participants
@haveric @kevingranade