Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubik's anesthetic quest #56546

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Apr 2, 2022

Summary

Bugfixes "Fix Rubik's anesthetic quest"

Purpose of change

Describe the solution

Switched anesthetic kits to just anesthetic. Made the quest completable only through dialogue.

Describe alternatives you've considered

None

Testing

Loaded up a game. Spawned in the overmap special for the exodii. Talked to Rubik until I could get the quest. Made sure that I wasn't autocompleting it just be having the kits on me and that talking to Rubik to finish the quest consumed only the anesthetic instead of the kits.

Additional context

Pinging @I-am-Erk for Rubik translation on my tweaked text.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 2, 2022
@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 2, 2022

We can probably drop this to one liter of anaesthetic while you're in there

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 2, 2022
@haveric
Copy link
Contributor Author

haveric commented Apr 2, 2022

We can probably drop this to one liter of anaesthetic while you're in there

Done. Let me know if there's any language you'd like to tweak.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 2, 2022
@sonphantrung
Copy link
Contributor

Quite dumb question, but are there any works on Rubik's CBM removal? Because I see that the PC spends 500$ for Rubik to remove their faulty bionics, only for him to break the character's limb

@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 3, 2022

It's debatable if they'd say "liter" but I am okay with leaving it clear rather than trying to work out something dialectic.

@I-am-Erk I-am-Erk merged commit add752e into CleverRaven:master Apr 3, 2022
@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 3, 2022

Quite dumb question, but are there any works on Rubik's CBM removal? Because I see that the PC spends 500$ for Rubik to remove their faulty bionics, only for him to break the character's limb

Is there an issue posted for that? if not there should be.

@haveric haveric deleted the fix-rubik-anesthetic branch April 3, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asking Rubik to cyborgify the PC incorrectly complains about the lack of an anesthesia kit
3 participants