Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't apply test labels if workflow was skipped #56536

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

Labeling based on workflow status sure is nice, lets you know stuff
compiles or passes the styling checks, however it becomes a lil bit
noisy if the thing also adds labels on a workflow skip aka to things
that have nothing to do with compiling or styling

Describe the solution

Describe alternatives you've considered

Testing

Here I had the labeler apply the json style ok label on workflow success but don't apply the cpp style ok label on workflow skip
casswedson#13

Additional context

Labeling based on workflow status sure is nice, lets you know stuff
compiles or passes the styling checks, however it becomes a lil bit
noisy if the thing also adds labels on a workflow skip aka to things
that have nothing to do with compiling or styling

fixup
@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 2, 2022
@kevingranade kevingranade merged commit ef0602b into CleverRaven:master Apr 6, 2022
@casswedson casswedson deleted the canyounot branch April 6, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants