Vehicle falls forever on skylight #56514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
kevingranade
reviewed
Apr 6, 2022
This was referenced May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Vehicle falls forever on skylight"
Purpose of change
Fixes #56477
Vehicles would fall infinitely if on a skylight, never breaking it or actually falling.
Also items or characters would fall through a skylight without breaking it.
Describe the solution
Remove the NO_FLOOR flag and the trap. This allows items to be supported by skylights.
Fix spelling error.
Justification: simplified skylight behaviour is better than its current buggy state.
Describe alternatives you've considered
Fix the code. Since this is such a rarely encountered terrain type, I am not enthusiastic about spending more time here.
Testing
Dragged luggage cart onto a hotel skylight. Luggage cart and player stay supported without falling. Furniture is not allowed on the tile, which is ok.
Additional context