Check more static translation calls and update message #56509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Clarify the error message for static translation calls and report more static translation calls.
Describe the solution
Check for more static translation calls that won't work as intended, including
translation::translated
,translation::translated_eq
,translation::translated_ne
, andtranslation::translated_lt
.Update the message and add documentation in
TRANSLATING.md
.Add missing comparison operators and function objects to
translation.h
.Testing
The lit test passes and static translation calls are reported both locally and in CI.
Additional context
The first commit contains a rename of the related files, so it's easier to review the commits separately.