Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check more static translation calls and update message #56509

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Apr 1, 2022

Summary

None

Purpose of change

Clarify the error message for static translation calls and report more static translation calls.

Describe the solution

Check for more static translation calls that won't work as intended, including translation::translated, translation::translated_eq, translation::translated_ne, and translation::translated_lt.

Update the message and add documentation in TRANSLATING.md.

Add missing comparison operators and function objects to translation.h.

Testing

The lit test passes and static translation calls are reported both locally and in CI.

Additional context

The first commit contains a rename of the related files, so it's easier to review the commits separately.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 1, 2022
@Qrox Qrox force-pushed the static-translation branch from ce4e6c9 to e8641ab Compare April 1, 2022 10:14
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 1, 2022
@Qrox Qrox marked this pull request as ready for review April 1, 2022 10:14
@kevingranade kevingranade merged commit 9c34046 into CleverRaven:master Apr 6, 2022
@Qrox Qrox deleted the static-translation branch April 17, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants