Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build the clang-tidy checks as an executable with CMake #56506

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Apr 1, 2022

Summary

Build "Add option to build the clang-tidy checks as an executable with CMake"

Purpose of change

Convert the temporary diff in doc/DEVELOPER_TOOLING.md to an actual implementation,

Describe the solution

Added a new CMake flag CATA_CLANG_TIDY_EXECUTABLE to build a custom executable. Updated the documentation accordingly.

Testing

Clang-tidy runs correctly locally and in CI.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 1, 2022
@Qrox Qrox force-pushed the clang-tidy-exe branch from f05aef4 to f2e2f83 Compare April 1, 2022 08:23
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 1, 2022
@kevingranade kevingranade merged commit ed36f6b into CleverRaven:master Apr 6, 2022
@Qrox Qrox deleted the clang-tidy-exe branch April 17, 2022 17:16
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
…file

ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Jul 22, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Aug 6, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Aug 15, 2023
ported from: CleverRaven/Cataclysm-DDA#56506

Co-authored-by: Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants