Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-zero price_postapoc to fasteners.json #56475

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

Inglonias
Copy link
Contributor

Summary

Balance "Made price_postapoc for fasteners non-zero"

Purpose of change

I noticed the refugee center was giving me all the zippers and buttons I wanted for free in the trade window.

Describe the solution

Make fasteners 10 cents across the board.

Describe alternatives you've considered

A different price

Testing

I'm feeling cocky and don't feel the need to test this.

Additional context

If I'm touching intended behavior, let me know.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 30, 2022
@Ilysen
Copy link
Contributor

Ilysen commented Mar 30, 2022

Thanks for fixing this; it was something that I kind of caused by adding them to Smokes's shop. There are still some things that can be bought for free from shops (i.e. rags), but that's a different problem. I'm wondering if there should be a minimum price that can be set for different shopkeepers, but they have so many other problems right now - like items that the player sells them never despawning - that it seems like a comparatively small thing.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 30, 2022
@PatrikLundell
Copy link
Contributor

That explains why these items were free in Rubik's shop as well.

@kevingranade kevingranade merged commit 790d3f4 into CleverRaven:master Apr 5, 2022
@Faalagorn
Copy link
Contributor

Thanks for fixing this; it was something that I kind of caused by adding them to Smokes's shop. There are still some things that can be bought for free from shops (i.e. rags), but that's a different problem. I'm wondering if there should be a minimum price that can be set for different shopkeepers, but they have so many other problems right now - like items that the player sells them never despawning - that it seems like a comparatively small thing.

Why items have 0 price in the first place through? To prevent selling them?

@Inglonias
Copy link
Contributor Author

I'm guessing that's it, yeah. That said, considering how many of these things you find, it may be worth lowering the price somewhat later.

@Inglonias Inglonias deleted the fasteners_price_check branch April 5, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants