Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark shout quotes to translation #56464

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

I18N "Allow the translation of shout dialog quote marks"

Purpose of change

Allow shout quote marks to be translated.

Describe the solution

Following the change in #56441, Surround the strings with _() function.

Describe alternatives you've considered

None.

Testing

Compiled game, pressed C, then b and typed asd and pressed enter to shout it with the Polish locale set:
Before:
screenshot_2022-03-29-233547
After:
screenshot_2022-03-29-234540

Additional context

None

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Mar 29, 2022
@Faalagorn Faalagorn changed the title Update npctalk.cpp Mark shout quotes to translation Mar 29, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 29, 2022
@kevingranade kevingranade merged commit a1320d9 into CleverRaven:master Apr 5, 2022
@Faalagorn Faalagorn deleted the patch-3 branch April 5, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants