Remove NEW! recipe flag on current item when moving up or down #56416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
NetSysFire
added
Info / User Interface
Drew4484
added a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
Apr 4, 2022
This reverts commit b66a9b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Remove NEW! recipe flag on current item when moving up or down"
Purpose of change
Purely a QOL change. No known issue.
When viewing recipes that have the NEW! status, it only toggles when the recipe is entered. When the first item upon entering the window is new, it does not get toggled off when moving up or down. Same issue when using page up or down. I found this to be an annoyance.
This simply toggles off the NEW! indicator when leaving the item via the up or down controls, as well as retaining the current behaviour.
Describe the solution
Added a variable to track the line number when leaving a line with the up or down controls.
Describe alternatives you've considered
Nothing simpler.
Testing
Viewed menus and tested out various key controls. Behaving as intended with no observed side-effects.
Additional context