Expanding bronze: Weapons #56381
Merged
Expanding bronze: Weapons #56381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
I think lower price is green if you want to buy the item, but yeah, it's confusing. Maybe worth changing the other way around? |
github-actions
bot
added
the
BasicBuildPassed
Drew4484
added a commit
to Drew4484/Cataclysm-DDA
that referenced
this pull request
Apr 4, 2022
This reverts commit 422846d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds more bronze weapons"
Purpose of change
Follow up on #55815
Adds three more survivor-grade bronze weapons: A sword, a spear and a mace.
The sword and spear are based on the xiphos and dory with lower damage and lower to-hit bonus.
The mace is an upgrade of the trench mace with higher damage and durability at the cost of more weight. It's still weaker than the actual mace.
Describe the solution
Added a bronze sword, which is a weaker version of the xiphos.
Added a bronze spear, which is a weaker version of the dory.
Added a bronze mace, which is between the trench mace and the mace.
Describe alternatives you've considered
Leaving bronze weapons as they are currently.
Or any tweaks to the added weapons.
I am completely open here.
Testing
Loaded the game without errors and crafted the weapons.
Additional context
Comparing the items:
I have no idea why lower price is green.