Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds repairs_like for cataphract armor and allows Thessalonian bronze to be repaired like normal bronze #56372

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Mar 27, 2022

Summary

Bugfixes "Cataphract armor and legguards are no longer very difficult to repair/refit/etc in normal play, and can be repaired in a similar way to normal bronze"

Purpose of change

Cataphract armor and leggings can technically be refitted, repaired, and reinforced using a sewing kit (since it has leather), but since it's uncraftable and lacks a repairs_like, it's almost impossible to actually do so unless you have an extremely high tailoring skill. Unlike normal bronze, it also cannot be repaired using the usual tools (welders and such) because it isn't defined in their item defs, even though Thessalonian bronze has scrap bronze defined as a repair material.

Fixes #52521

Describe the solution

  • Cataphract armor now repairs like the bell cuirass; cataphract leggings now repairs like bronze greaves.
  • Added fancy_bronze to the materials list for the arc welder, makeshift arc welder, and extended multitool. Also added it to the blacksmith repair kit in the Innawoods mod.

Describe alternatives you've considered

  • This PR could just introduce the repairs_like and continue to not let Thessalonian bronze be repairable using the traditional methods. I'm fine with that if we'd like to go that route.
  • In the stated issue Erk mentioned that the armor would ideally require actual bronze scales to repair instead, but I don't believe that per-item repair costs are currently possible; only per-material. Since the rest of the game currently allows this type of repair, I went with that instead.
  • This particular type of armor is only available from the Exodii due to not being native to Earth, so there's a fair argument to be made that it wouldn't be repairable at all without more info on its design. I decided against this because I felt that the high requirements to do anything with it were an adequate representation of the intuition needed to work with a design that's new to you, like your character is described as modifying the nomad jumpsuit (or was it bodyglove?) to fit small anatomies if you craft an XS version.

Testing

Spawn in some cataphract armor and try different tailoring skills to refit/etc it. See that you can only do things like refitting at level 10 tailoring. Apply changes and see that the issue's fixed.

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 27, 2022
@LyleSY LyleSY added the Mods: Innawood 🌲 Anything to do with Innawood mod label Mar 29, 2022
@kevingranade kevingranade merged commit 29a2c2b into CleverRaven:master Apr 5, 2022
@Ilysen Ilysen deleted the cataphract-repairs-like branch April 6, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thessalonian Bronze can't be repaired with welder
4 participants