Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keybindings in Sort Armor's F1 help menu #56362

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Mar 26, 2022

Summary

Bugfixes "Fix keybindings in Sort Armor's F1 help menu"

Purpose of change

Fix listed keybindings. Looks like this might have gotten missed from #52054

Describe the solution

Add the toggle armor description to match the variables.

Describe alternatives you've considered

Remove keybindings from the F1 help menu

Testing

Loaded up the game.
Pressed =(Shift +) to open the Sort Armor menu.
Pressed F1 to view help.
See correct keybindings, including the new one.

Additional context

Should this have been failing some test by adding more variables than existed? I'm pretty sure it fails correctly the other way around, but this should probably be caught automatically in the future.

Before (from @Faalagorn on discord):
image

After:
image

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 26, 2022
@kevingranade kevingranade merged commit 54c6920 into CleverRaven:master Mar 27, 2022
@haveric haveric deleted the sort-armor-help branch March 27, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants