Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plantain → cooking banana #56346

Merged
merged 2 commits into from
Mar 27, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Unify the "cooking banana" name.

Describe the solution

Change "plantain" to "cooking banana".

Describe alternatives you've considered

Leave it as is.

Testing

Name change, can be seen when spawning an item.

Additional context

Fixes Transifex issue.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 25, 2022
@haveric
Copy link
Contributor

haveric commented Mar 25, 2022

Why not switch these to just be called plantains everywhere? I feel like "cooked cooking banana" is unnecessary here. (Note that I know nothing about these plants and have no idea if there's an actual difference, but from what I can find, plantain is the common name for them)

@Sathra225
Copy link
Contributor

Ehh, kinda. Plantains are kind of like potatoes. You actually have to cook them for them to be reasonably edible (chalky and astringent). However, not all cooking bananas are plantains, while all plantains are cooking bananas.
For general use, plantains is used for all cooking bananas, but technically its only for certain types.

Besides that, cooked cooking banana does sound silly. So either changing the item name of 'cooking banana' to plantain, or changing the recipe string to 'roasted cooking banana' would be good.

@Faalagorn
Copy link
Contributor Author

Why not switch these to just be called plantains everywhere? I feel like "cooked cooking banana" is unnecessary here. (Note that I know nothing about these plants and have no idea if there's an actual difference, but from what I can find, plantain is the common name for them)

I thought about it and what @Sathra225 mention is a valid point too. What do you think then? Plantain for everything or roasted?

@Zireael07
Copy link
Contributor

Nitpick: non-native English speaker here, I wouldn't know what a plantain is, I suggest "cooking banana" and "roasted cooking banana". If you do go with plantain, please leave a translator comment.

@Faalagorn
Copy link
Contributor Author

Commited the roasted one for now :)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 26, 2022
@NetSysFire
Copy link
Member

I wouldn't know what a plantain is

Fun fact, there is a common weed in New England which goes by the name plantain, too. So clarifying that is definitely the right step.

https://gobotany.nativeplanttrust.org/species/plantago/major/

@kevingranade kevingranade merged commit 2e60697 into CleverRaven:master Mar 27, 2022
@Faalagorn Faalagorn deleted the patch-1 branch March 27, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants