-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plantain → cooking banana #56346
plantain → cooking banana #56346
Conversation
Why not switch these to just be called plantains everywhere? I feel like "cooked cooking banana" is unnecessary here. (Note that I know nothing about these plants and have no idea if there's an actual difference, but from what I can find, plantain is the common name for them) |
Ehh, kinda. Plantains are kind of like potatoes. You actually have to cook them for them to be reasonably edible (chalky and astringent). However, not all cooking bananas are plantains, while all plantains are cooking bananas. Besides that, cooked cooking banana does sound silly. So either changing the item name of 'cooking banana' to plantain, or changing the recipe string to 'roasted cooking banana' would be good. |
I thought about it and what @Sathra225 mention is a valid point too. What do you think then? Plantain for everything or roasted? |
Nitpick: non-native English speaker here, I wouldn't know what a plantain is, I suggest "cooking banana" and "roasted cooking banana". If you do go with plantain, please leave a translator comment. |
Commited the roasted one for now :) |
Fun fact, there is a common weed in New England which goes by the name plantain, too. So clarifying that is definitely the right step. https://gobotany.nativeplanttrust.org/species/plantago/major/ |
Summary
None
Purpose of change
Unify the "cooking banana" name.
Describe the solution
Change "plantain" to "cooking banana".
Describe alternatives you've considered
Leave it as is.
Testing
Name change, can be seen when spawning an item.
Additional context
Fixes Transifex issue.