Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typo hunting ft. codespell #56320

Merged
merged 3 commits into from
Mar 27, 2022
Merged

chore: typo hunting ft. codespell #56320

merged 3 commits into from
Mar 27, 2022

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

I discovered codespell yesterday while looking at the vim repo
I like it, I use it here

Describe the solution

Describe alternatives you've considered

Testing

Only modified strings and comments

Additional context

@casswedson
chore: typo hunting ft. codespell
b4cf6a6 
I discovered codespell yesterday while looking at the vim repo
I like it, I use it here
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Aftershock Anything to do with the Aftershock mod Mods: Dark Skies Anything to do with Dark Skies Above, alien invasion mod with no zombies Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Magiclysm Anything to do with the Magiclysm mod Mods: MMA Mythical Martial Arts mod Mods: No Hope Relating to the mod No Hope NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions labels Mar 24, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • "can sunstasin self frorever off for my funggnaloid babiues oout fo yme arms eat themm up eatbtb my chidlldren"

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 24, 2022
NetSysFire
NetSysFire approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@NetSysFire NetSysFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall holy smokes, that is a LOT of typos. Nice work hunting those down.

data/json/snippets/graffiti.json Outdated Show resolved Hide resolved
data/json/snippets/survivor_notes.json Outdated Show resolved Hide resolved
src/panels.cpp Outdated Show resolved Hide resolved
src/savegame.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 24, 2022
NetSysFire
NetSysFire reviewed Mar 24, 2022
View reviewed changes
data/mods/Magiclysm/Spells/attunements/Shapeshifter.json Outdated Show resolved Hide resolved
src/construction.cpp Outdated Show resolved Hide resolved
src/vehicle.h Outdated Show resolved Hide resolved
data/json/npcs/Backgrounds/gung_ho_1.json Outdated Show resolved Hide resolved
@KorGgenT
Copy link
Member

i only looked at the magiclysm stuff and magic.h, and while i'm generally against the code churn that is correcting typos in comments, it looks fine to me. especially since this PR isn't gigantic like some others have been.

@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Mar 27, 2022
@kevingranade kevingranade merged commit e699348 into CleverRaven:master Mar 27, 2022
@casswedson casswedson deleted the typo-hunting branch March 27, 2022 19:03
Faalagorn
Faalagorn reviewed Mar 27, 2022
View reviewed changes
src/item.cpp
@@ -12652,7 +12652,7 @@ bool item::process_internal( Character *carrier, const tripoint &pos,
return true;
}
} else {
// guns are never active so we only need thck this on inactive items. For performance reasons.
// guns are never active so we only need thick this on inactive items. For performance reasons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "tick"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it should be tick, I can't believe I missed that

@casswedson casswedson mentioned this pull request May 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetSysFire NetSysFire NetSysFire approved these changes

@Faalagorn Faalagorn Faalagorn left review comments

@LyleSY LyleSY LyleSY approved these changes

@I-am-Erk I-am-Erk Awaiting requested review from I-am-Erk

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

@Night-Pryanik Night-Pryanik Awaiting requested review from Night-Pryanik

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Mom-Bun Mom-Bun Awaiting requested review from Mom-Bun

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dark Skies Anything to do with Dark Skies Above, alien invasion mod with no zombies Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Magiclysm Anything to do with the Magiclysm mod Mods: MMA Mythical Martial Arts mod Mods: No Hope Relating to the mod No Hope NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@casswedson @KorGgenT @Faalagorn @LyleSY @NetSysFire @kevingranade