Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heavy-duty → heavy duty #56267

Closed
wants to merge 1 commit into from
Closed

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Unify spelling of heavy duty.

Describe the solution

Change all the remaining instances of heavy-duty to heavy duty.

Describe alternatives you've considered

  • Change all the remaining instances of heavy duty to heavy-duty.
  • Leave both.

Testing

Seems to compile fine, can be seen by spawning stuff in question and one changed comment should be seen in Transifex afterwards.

Additional context

Fixes an issue in Transifex.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 21, 2022
@haveric
Copy link
Contributor

haveric commented Mar 21, 2022

This is an interesting one that I think makes more sense the other way around in order to avoid confusion in a handful of situations. An article that explains why: https://english.stackexchange.com/questions/404839/should-heavy-duty-always-be-hyphenated-when-used-as-an-adjective

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 21, 2022
@Faalagorn
Copy link
Contributor Author

@haveric So what your opinion would be? To change it all around, or rather, case-by-case? I'd love to see ither opinions, maybe some style guide consesnus on using hyphen, similar how the serial comma is used.

While I get the possible ambiguity that can result from not using a hyphen, one thing that got me thinking was one of the reply that "but apparently Americans are more likely to discard the hyphen than Brits, according to that NGram"

@haveric
Copy link
Contributor

haveric commented Mar 22, 2022

So what your opinion would be?

I'm leaning towards heavy-duty everywhere. Either way you choose, we should stay consistent, so I would avoid mixing the two. Are there any instances of translating this where it changes the meaning depending on which is used? (I played with google translate and there's a handful different there, but I don't know how accurate or relevant they are and I'm not sure how easy this is to answer)

"but apparently Americans are more likely to discard the hyphen than Brits, according to that NGram"

I saw this as well, but with it having various usages, I would lean toward using the one that removes any confusion when reading.

Also, actual NGram usage seems to disagree with that statement (or the statement is poorly worded, we may discard it more than Brits, but we still use it more compared to the alternatives):
https://books.google.com/ngrams/graph?content=heavy-duty%2Cheavy+duty%2Cheavyduty&year_start=1800&year_end=2019&corpus=28&smoothing=3&direct_url=t1%3B%2Cheavy%20-%20duty%3B%2Cc0%3B.t1%3B%2Cheavy%20duty%3B%2Cc0%3B.t1%3B%2Cheavyduty%3B%2Cc0

https://books.google.com/ngrams/graph?content=heavy-duty+plastic%2Cheavy+duty+plastic%2Cheavyduty+plastic&year_start=1800&year_end=2019&corpus=28&smoothing=3&direct_url=t1%3B%2Cheavy%20-%20duty%20plastic%3B%2Cc0%3B.t1%3B%2Cheavy%20duty%20plastic%3B%2Cc0%3B.t1%3B%2Cheavyduty%20plastic%3B%2Cc0

@Faalagorn
Copy link
Contributor Author

I think I'll keep this PR as is for now, as changing it the other way around would be actually more work than doing the new PR; if a hyphen one would be preferred though, we should make a new PR for that :)

@haveric
Copy link
Contributor

haveric commented Apr 6, 2022

Should this one be closed now that your other PR was created?

@Faalagorn Faalagorn deleted the patch-7 branch April 6, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants