-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heavy-duty → heavy duty #56267
heavy-duty → heavy duty #56267
Conversation
This is an interesting one that I think makes more sense the other way around in order to avoid confusion in a handful of situations. An article that explains why: https://english.stackexchange.com/questions/404839/should-heavy-duty-always-be-hyphenated-when-used-as-an-adjective |
@haveric So what your opinion would be? To change it all around, or rather, case-by-case? I'd love to see ither opinions, maybe some style guide consesnus on using hyphen, similar how the serial comma is used. While I get the possible ambiguity that can result from not using a hyphen, one thing that got me thinking was one of the reply that "but apparently Americans are more likely to discard the hyphen than Brits, according to that NGram" |
I'm leaning towards
I saw this as well, but with it having various usages, I would lean toward using the one that removes any confusion when reading. Also, actual NGram usage seems to disagree with that statement (or the statement is poorly worded, we may discard it more than Brits, but we still use it more compared to the alternatives): |
I think I'll keep this PR as is for now, as changing it the other way around would be actually more work than doing the new PR; if a hyphen one would be preferred though, we should make a new PR for that :) |
Should this one be closed now that your other PR was created? |
Summary
None
Purpose of change
Unify spelling of heavy duty.
Describe the solution
Change all the remaining instances of heavy-duty to heavy duty.
Describe alternatives you've considered
Testing
Seems to compile fine, can be seen by spawning stuff in question and one changed comment should be seen in Transifex afterwards.
Additional context
Fixes an issue in Transifex.