fix: don't validate empty summary descriptions #56227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
astyled
casswedson
changed the title
github-actions
bot
added
the
BasicBuildPassed
Maleclypse
added
the
Code: Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Summary lines should consist of a category and a brief description, this makes the pull request validator fail on submissions such as this one
Category ""Describe the solution
TLDR;
.here means any character except line terminators".*"matches anything and nothing".+"matches anything but has to be somethingDescribe alternatives you've considered
Testing
Changed my summary here to demonstrate #56216
Additional context