Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosin-Nagant 91/30 Boreal → 1891/30 Boreal #56194

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Unify name of Mosins in the game.
screenshot_2022-03-18-193114

Describe the solution

Change "91/30" to full "1891/30" for Mosin Boreal.

Describe alternatives you've considered

None.

Testing

Simple name change, can be seen e.g. when spawning items.

Additional context

Originally found in Transifex, discussed again on Discord following one for the recent changes.

Update Magiclysm Mosin name to match other
@Faalagorn Faalagorn requested a review from KorGgenT as a code owner March 18, 2022 18:32
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 18, 2022
@KorGgenT KorGgenT merged commit 1b95893 into CleverRaven:master Mar 19, 2022
@Faalagorn Faalagorn deleted the patch-4 branch March 19, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants