Add id_suffix to shadowed recipes (#56161) #56177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves CleverRaven#56161 * Un-shadowed the following recipes, allowing them to be crafted: * armor_scrapsuit * armor_tiresuit * chem_hmtd * chem_nitric_acid * gambeson_vest * gambeson_vest_xs * k_gambeson_vest * k_gambeson_vest_xs * lc_chainmail_arms * pistol_stock * pot_copper * propane_cooker * thread (Spinning Wheel versions) * tshirt * xl_ch_chainmail_hood * xl_gambeson_vest * xl_hc_chainmail_hood * xl_k_gambeson_vest * xl_lc_chainmail_arms * xl_lc_chainmail_hood * xl_mc_chainmail_hood * xl_qt_chainmail_hood * xs_armor_lightplate
|
Some of the recipes added in #55455 vary their multiplier on the It seems like recipes requiring a higher amount of charges to finish would also require a higher amount of materials (or lower quality base materials) but that's not how the recipes are defined. Likewise for the recipes requiring less charges, they require the same amount of materials. I'm honestly not sure what the intent is here. Since I just wanted to fix the shadowing issue I didn't modify the requirements or recipes as I'm not sure what the original author's vision is. |
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56161
Summary
None
Purpose of change
Fixes #56161
Describe the solution
Added
id_suffixto listed recipes so that their derived IDs will be unique, ensuring they do not conflict.In three cases (
lc_chainmail_arms,xs_lc_chainmail_arms, andxl_lc_chainmail_arms) the recipe was duplicated so I deleted the duplicate entries.Describe alternatives you've considered
None
Testing
Additional context