-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDotD] Remove post-period tech, rename some firearms #55864
Merged
I-am-Erk
merged 1 commit into
CleverRaven:master
from
TheShadowFerret:DDotD-GunBlacklists
Apr 1, 2022
Merged
[DDotD] Remove post-period tech, rename some firearms #55864
I-am-Erk
merged 1 commit into
CleverRaven:master
from
TheShadowFerret:DDotD-GunBlacklists
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Json
Mods: Dark Days of the Dead
Anything related to the DDotD mod (classic style zombies)
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 6, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 6, 2022 08:07
97d10c8
to
56d4c1c
Compare
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 6, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
3 times, most recently
from
March 6, 2022 22:58
9760f4b
to
47db7de
Compare
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 6, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 10, 2022 00:36
47db7de
to
8a71fab
Compare
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
3 times, most recently
from
March 11, 2022 04:54
b372334
to
fd34230
Compare
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 11, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
3 times, most recently
from
March 12, 2022 00:01
30a5a61
to
c154127
Compare
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 12, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
10 times, most recently
from
March 12, 2022 01:17
e2ef856
to
3ce2acc
Compare
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
2 times, most recently
from
March 12, 2022 01:51
6286a2a
to
c16f60b
Compare
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 12, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 12, 2022 02:02
c16f60b
to
1843e1c
Compare
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 12, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 13, 2022 13:33
36eb8a1
to
af41c8b
Compare
TheShadowFerret
changed the title
[DDotD] Remove post-period tech
[DDotD] Remove post-period tech, rename some firearms
Mar 13, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 13, 2022 13:42
af41c8b
to
b0f6db6
Compare
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 20, 2022 22:10
b0f6db6
to
d6b125a
Compare
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Mar 20, 2022
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
2 times, most recently
from
March 21, 2022 00:33
002d64b
to
32ea45f
Compare
TheShadowFerret
force-pushed
the
DDotD-GunBlacklists
branch
from
March 30, 2022 21:45
32ea45f
to
0feed46
Compare
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Mar 31, 2022
Nice, thank you! |
NetSysFire
added
the
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
label
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Dark Days of the Dead
Anything related to the DDotD mod (classic style zombies)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Remove futuretech from DDotD"
Purpose of change
There are no aliens or interdimensional threats in DDotD.
## Setting The setting of DDotD should be vaguely "in the past", some time between 1980 and 2000. DDotD takes place in Alberta, Canada, in a fictionalized version of the Red Deer area.
~DDotD Design documentDescribe the solution
Remove technology that comes from interdimensional or alien sources, plus guns from after 2000. This includes mutagen, energy weapons, & bionics.
Rename military rifles to their Canadian designations.
Migrate the M17 and M18 to the Browning Hi-Power so military pistol spawns also change.
Describe alternatives you've considered
Doing something to the guns included by Former Prohibited Weapons Orders no. 12 and 13, which came into effect in 92 and 95 respectively.
Removing the H&K UMP and McMillan TAC-50 for being at the very end of the stated time period (2000).
Switching all the blacklists to migrations.
Testing
Load game to get no errors at start, select Military Pilot and Military Recruit to see that their guns migrated.
Generic Guns + DDoTD: Load game, guns that were renamed still genericize.
Additional context
In no way should this be considered a full audit, since I didn't change weightings & I don't know the history of Canadian firearm law to remove additional guns.
Sources on gun dates that weren't "just Wikipedia search the name":
Marlin 1895 SBL(2009): https://www.outdoorcanada.ca/rifle-review-we-test-the-big-bore-marlin-1895sbl/
Magnum Research BFRs(2001, check the 20th anniversary tab): https://www.magnumresearch.com/bfr-biggest-finest-revolver/
Kord 6P67(2014?): https://modernfirearms.net/en/assault-rifles/russia-assault-rifles/a545-kord-5-45-6p67-2/
Big Horn Model 89 & S&W 500: Caliber debuted in 2003
Taurus Spectrum(2017): https://www.handgunsmag.com/editorial/taurus-spectrum-380-acp/331168
.300 AAC Blackout: Caliber started development in 2009.
M249 Semi(2017 from Military Collector Series): https://www.ammoland.com/2017/08/fnh-m249s-saw-light-machine-gun/
Henry Big Boy(2003): https://www.americanrifleman.org/content/a-hard-look-at-henry-lever-actions/
AF2011A1: ..... bap
Glock 40 MOS(2015): https://www.thetruthaboutguns.com/shot-show-glock-40-mos-10mm/
SIG P220 10mm(2015): https://www.gunsamerica.com/digest/sigs-new-220-10mm-bigger-better-shot-show-2015/
PTR 603: PTR started in 2002 https://ptr-us.com/history/