Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDotD] Remove post-period tech, rename some firearms #55864

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

TheShadowFerret
Copy link
Contributor

@TheShadowFerret TheShadowFerret commented Mar 6, 2022

Summary

Mods "Remove futuretech from DDotD"

Purpose of change

There are no aliens or interdimensional threats in DDotD.

## Setting The setting of DDotD should be vaguely "in the past", some time between 1980 and 2000. DDotD takes place in Alberta, Canada, in a fictionalized version of the Red Deer area.~DDotD Design document

Describe the solution

Remove technology that comes from interdimensional or alien sources, plus guns from after 2000. This includes mutagen, energy weapons, & bionics.

Rename military rifles to their Canadian designations.
Migrate the M17 and M18 to the Browning Hi-Power so military pistol spawns also change.

Describe alternatives you've considered

Doing something to the guns included by Former Prohibited Weapons Orders no. 12 and 13, which came into effect in 92 and 95 respectively.

Removing the H&K UMP and McMillan TAC-50 for being at the very end of the stated time period (2000).

Switching all the blacklists to migrations.

Testing

Load game to get no errors at start, select Military Pilot and Military Recruit to see that their guns migrated.

Generic Guns + DDoTD: Load game, guns that were renamed still genericize.

Additional context

In no way should this be considered a full audit, since I didn't change weightings & I don't know the history of Canadian firearm law to remove additional guns.

Sources on gun dates that weren't "just Wikipedia search the name":
Marlin 1895 SBL(2009): https://www.outdoorcanada.ca/rifle-review-we-test-the-big-bore-marlin-1895sbl/
Magnum Research BFRs(2001, check the 20th anniversary tab): https://www.magnumresearch.com/bfr-biggest-finest-revolver/
Kord 6P67(2014?): https://modernfirearms.net/en/assault-rifles/russia-assault-rifles/a545-kord-5-45-6p67-2/
Big Horn Model 89 & S&W 500: Caliber debuted in 2003
Taurus Spectrum(2017): https://www.handgunsmag.com/editorial/taurus-spectrum-380-acp/331168
.300 AAC Blackout: Caliber started development in 2009.
M249 Semi(2017 from Military Collector Series): https://www.ammoland.com/2017/08/fnh-m249s-saw-light-machine-gun/
Henry Big Boy(2003): https://www.americanrifleman.org/content/a-hard-look-at-henry-lever-actions/
AF2011A1: ..... bap
Glock 40 MOS(2015): https://www.thetruthaboutguns.com/shot-show-glock-40-mos-10mm/
SIG P220 10mm(2015): https://www.gunsamerica.com/digest/sigs-new-220-10mm-bigger-better-shot-show-2015/
PTR 603: PTR started in 2002 https://ptr-us.com/history/

@github-actions github-actions bot added Json Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 6, 2022
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 6, 2022
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 3 times, most recently from 9760f4b to 47db7de Compare March 6, 2022 22:58
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 6, 2022
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 10, 2022
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 3 times, most recently from b372334 to fd34230 Compare March 11, 2022 04:54
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 11, 2022
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 3 times, most recently from 30a5a61 to c154127 Compare March 12, 2022 00:01
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 12, 2022
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 10 times, most recently from e2ef856 to 3ce2acc Compare March 12, 2022 01:17
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 2 times, most recently from 6286a2a to c16f60b Compare March 12, 2022 01:51
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 12, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Mar 12, 2022
@TheShadowFerret TheShadowFerret marked this pull request as ready for review March 12, 2022 02:14
@BrettDong BrettDong removed the Json label Mar 12, 2022
@TheShadowFerret TheShadowFerret changed the title [DDotD] Remove post-period tech [DDotD] Remove post-period tech, rename some firearms Mar 13, 2022
@TheShadowFerret TheShadowFerret marked this pull request as draft March 20, 2022 22:37
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 20, 2022
@TheShadowFerret TheShadowFerret force-pushed the DDotD-GunBlacklists branch 2 times, most recently from 002d64b to 32ea45f Compare March 21, 2022 00:33
@TheShadowFerret TheShadowFerret marked this pull request as ready for review March 21, 2022 00:34
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 31, 2022
@I-am-Erk
Copy link
Member

I-am-Erk commented Apr 1, 2022

Nice, thank you!

@I-am-Erk I-am-Erk merged commit baea7e2 into CleverRaven:master Apr 1, 2022
@NetSysFire NetSysFire added the Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves label Apr 1, 2022
@TheShadowFerret TheShadowFerret deleted the DDotD-GunBlacklists branch April 1, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants