Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flint and steel recipe #55842

Merged
merged 6 commits into from
Apr 22, 2022
Merged

Add flint and steel recipe #55842

merged 6 commits into from
Apr 22, 2022

Conversation

AtomicFox556
Copy link
Contributor

Summary

Content "Add flint and steel recipe"

Purpose of change

Add a way to make flint and steel, an item to start a fire.

Describe the solution

Add a recipe for flint and steel.
It turned out that it was impossible to disassemble low/medium/high carbon steel lumps into chunks; this was corrected, though suggestions regarding tools needed for that are welcome.
High carbon steel chunks were also added as a component to all flintlock weapon recipes, as they presumably operate on the same principle as flint and steel and thus would need high carbon steel for the frizzen as well.

Describe alternatives you've considered

None.

Testing

Launched the game with changes, crafted flint and steel and made sure that it works for starting fires.

Additional context

None.

@github-actions github-actions bot added Json json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 5, 2022
@Maleclypse Maleclypse added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Mar 6, 2022
@BrettDong BrettDong removed the Json label Mar 12, 2022
@AtomicFox556
Copy link
Contributor Author

Is there anything preventing this from being merged?

@kevingranade
Copy link
Member

Like I said, treating every flaking stone as flint is a problem, this hasn't been adressed.

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Apr 5, 2022
@AtomicFox556
Copy link
Contributor Author

Done.

@github-actions github-actions bot added Spawn Creatures, items, vehicles, locations appearing on map and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 5, 2022
@AtomicFox556
Copy link
Contributor Author

I'll look at the errors later.

@AtomicFox556
Copy link
Contributor Author

Ready now.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 6, 2022
@I-am-Erk I-am-Erk merged commit b2a2245 into CleverRaven:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants