-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flint and steel recipe #55842
Merged
Merged
Add flint and steel recipe #55842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Json
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 5, 2022
Maleclypse
added
the
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
label
Mar 6, 2022
kevingranade
reviewed
Mar 9, 2022
Is there anything preventing this from being merged? |
Like I said, treating every flaking stone as flint is a problem, this hasn't been adressed. |
Done. |
github-actions
bot
added
Spawn
Creatures, items, vehicles, locations appearing on map
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Apr 5, 2022
I'll look at the errors later. |
Ready now. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 6, 2022
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Add flint and steel recipe"
Purpose of change
Add a way to make flint and steel, an item to start a fire.
Describe the solution
Add a recipe for flint and steel.
It turned out that it was impossible to disassemble low/medium/high carbon steel lumps into chunks; this was corrected, though suggestions regarding tools needed for that are welcome.
High carbon steel chunks were also added as a component to all flintlock weapon recipes, as they presumably operate on the same principle as flint and steel and thus would need high carbon steel for the frizzen as well.
Describe alternatives you've considered
None.
Testing
Launched the game with changes, crafted flint and steel and made sure that it works for starting fires.
Additional context
None.