Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ACT_CLEAR_RUBBLE to the new activity actor system. #55720

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

ahmedcharles
Copy link
Contributor

Summary

Infrastructure "Migrate ACT_CLEAR_RUBBLE to the new activity actor system."

Purpose of change

#40013

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 27, 2022
@NetSysFire NetSysFire added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Feb 27, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 27, 2022
@ahmedcharles ahmedcharles force-pushed the clearrubble branch 2 times, most recently from 4ea13c7 to 4f3790b Compare March 10, 2022 08:34
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 10, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 19, 2022
@ahmedcharles ahmedcharles force-pushed the clearrubble branch 2 times, most recently from c4d05c8 to 1b50a14 Compare March 27, 2022 02:34
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 27, 2022
@Maleclypse
Copy link
Member

There seem to be a number of failures on this possibly including astyle. Are you able to address the errors the tests are coming back with?

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 8, 2022
@ahmedcharles
Copy link
Contributor Author

ahmedcharles commented Apr 8, 2022

I fixed the astyle issues. I'm not sure why the test is failing. Any ideas? I'm not really very familiar with the code, I'm mostly using this as a way to get more familiar.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 8, 2022
@Maleclypse
Copy link
Member

I fixed the astyle issues. I'm not sure why the test is failing. Any ideas? I'm not really very familiar with the code, I'm mostly using this as a way to get more familiar.

[](https://github.com/CleverRaven/Cataclysm-DDA/runs/5879312427?check_suite_focus=true)clear_rubble_activity_actor( int moves ) : moves( moves ) {}
 Check failure on line 1773 in src/activity_actor_definitions.h

GitHub Actions
/ build
src/activity_actor_definitions.h#L1773
single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor,-warnings-as-errors]

I don't know enough about c++ to know exactly what that means so I googled it and this looks like it explains why you are getting that error and how to fix it. https://rules.sonarsource.com/cpp/RSPEC-1709

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 8, 2022
@kevingranade kevingranade merged commit d5c61d0 into CleverRaven:master Apr 9, 2022
@ahmedcharles ahmedcharles deleted the clearrubble branch April 10, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants