Replace hard steel with tempered steel

[Drew4484]

Summary

Content "Removes hardsteel, uses tempered steel in place."

Purpose of change

Hardsteel is not clearly defined and only used for a few applications. Changing this to tempered steel removes an uncommon material and allows the player to create the vehicle plating items.

Describe the solution

Removes hardsteel material. Changes items using hardsteel to qt_steel.

Describe alternatives you've considered

Trying to pin down what hardsteel is supposed to represent IRL.

Testing

Loaded game, no errors. Installed heavy plating and ram.

Additional context

As far as I can tell, hard steel is supposed to be something like RHA, but it isn't used consistently. RHA is almost certainly out of survivor crafting, a replacement using a craftable steel makes sense to me.

[Night-Pryanik]

You know, you ain't really removing this material yet. There's material definition in materials.json, there's several occurrences of it in the code etc which needs to be removed as well.

[Drew4484]

You know, you ain't really removing this material yet. There's material definition in materials.json, there's several occurrences of it in the code etc which needs to be removed as well.

I hadn't deleted the material just yet because it breaks some mods and I need to check with the owners on those before I change their gear, but that's the end goal.

[Night-Pryanik]

If you're actively working on the PR, consider converting it to draft.

[Drew4484]

If you're actively working on the PR, consider converting it to draft.

Sorry about that, you were probably getting bombed with notifications. I was working on my phone and doing tiny edits, I've drafted this again and will keep it that way until I've squashed the errors.

[dseguin]

You'll also need to update the value on line 1292 of tests/iteminfo_test.cpp:

diff --git a/tests/iteminfo_test.cpp b/tests/iteminfo_test.cpp
index e17f009ce0..027fe027d0 100644
--- a/tests/iteminfo_test.cpp
+++ b/tests/iteminfo_test.cpp
@@ -1289,7 +1289,7 @@ TEST_CASE( "armor protection", "[iteminfo][armor][protection]" )
         item super_tanktop( "test_complex_tanktop" );
         REQUIRE( super_tanktop.get_covered_body_parts().any() );
         // these values are averaged values but test that assumed armor portion is working at all
-        expected_armor_values( super_tanktop, 14, 18, 14.4f, 10.66667f );
+        expected_armor_values( super_tanktop, 14, 14, 14.4f, 10.66667f );
 
         // Protection info displayed on two lines
         CHECK( item_info_str( super_tanktop, more_protection ) ==

[lgtm-com]

LGTM pull request analysis was skipped for b079dfa by Drew4484. Analysis of future commits will happen as normal.