Build fire ring underground #55569
Merged
Build fire ring underground #55569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Light-Wave
changed the title
github-actions
bot
added
astyled
Light-Wave
changed the title
curstwist
added
Crafting / Construction / Recipes
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fire Ring can be built on underground dirt and rock floors"
Purpose of change
#54386 unintentionally made it much harder to build a fire ring in a cave. This change fixes that, and also makes it possible to build the ring on rock floors.
Describe the solution
Add a new recipe for f_firering that can be built on top of t_dirt_underground, and another that can be built on t_rock_floor.
The version built on rock floor does not need a digging implement.
Describe alternatives you've considered
Keep the digging implement requirement for rock floor, or require a pickaxe instead?
Let the fire ring be built on any fire safe terrain?
Testing
I built a fire ring underground and deconstructed it, and it seemed to work out fine. Did the same on rock floor.
Additional context
Useful for Innawood cave starts.