Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog functions for portal storm doors opening/closing and being taken away briefly. #55538

Merged
merged 7 commits into from
Feb 21, 2022

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Feb 20, 2022

Summary

None

Purpose of change

Part of #52475
Add portal effect to open and then close nearby doors.
Add portal effect to capture player in small cell for a little while.

Describe the solution

Cleaned up and fixed ter_furn_transform. Removed the fail message which did nothing and got messages to work more tightly linked to happening.
Added new mapgen flag to prevent rotating the tile even if the underlying one is.
Added z offset to u_location_variable.

Describe alternatives you've considered

Different fixes to ter_furn_transform.
Maybe an overall success message rather than repeating it so much?
Fixing fail message rather than removal. It's barely used and complicates things more than it's worth.
Adding some sort of special door transform effect rather than the giant ugly transform.

Testing

Additional context

@Ramza13 Ramza13 requested a review from KorGgenT as a code owner February 20, 2022 19:41
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 20, 2022
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Feb 20, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 20, 2022
@Maleclypse Maleclypse added Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mechanics: Weather Rain, snow, portal storms and non-temperature environment [Markdown] Markdown issues and PRs Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON labels Feb 21, 2022
@kevingranade kevingranade merged commit c468f8f into CleverRaven:master Feb 21, 2022
linonetwo added a commit to linonetwo/CDDA-Kenan-Modpack-Chinese that referenced this pull request Feb 21, 2022
@Ramza13 Ramza13 deleted the new_transforms branch February 21, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mechanics: Weather Rain, snow, portal storms and non-temperature environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants