Add a dive shop location

[ccaviness]

Summary

Content "Add a dive shop location"

Purpose of change

Add a new dive shop location to provide another location for sourcing
neoprene and other SCUBA related items.

Describe the solution

Add a dive shop with two variations. One has an open class area and a
small pool in the back, as well as a spot for refilling SCUBA tanks, and
a small mob of pool monsters. The other has a larger separate
classroom and more sales floor space.

Describe alternatives you've considered

Not adding content.

Testing

Spawned using overmap editor, and examined the building. Also verified
the dive shop is showing up in cities at a reasonable rate.

Additional context

Dive shop with classroom:

Dive shop with pool:

[ccaviness]

This is the first bit of content I've tried creating, so please let me know if I've done something incorrectly. I started out by copying the antique store and making some changes. I don't know if my edits to data/json/overmap/multitile_city_buildings.json are correct; I made them to match what I found when looking for antique store references.

[Night-Pryanik]

Overall looking good.

Nitpicks:

1. Classroom variant could use a toilet. You know, sellers are people with needs too.
2. Wardrobes in a shop look slightly out of place. Wardrobe is an opaque wooden cabinet more fitting for a house rather than a shop. Maybe replace them with locker or glass front cabinet?
3. weight field is useful only if you plan to make variants differ by rarity. If they all have the same chance to spawn, this field is redundant. It's not an error though.
4. Consider adding floor plants or vending machines.
5. Consider replacing wooden t_floor tiles around the pool with something more water-resistant.
6. Consider adding books on swimming in classroom variation.
7. Consider adding windows in a classroom.
8. Consider adding air condition units.

[ccaviness]

Thanks for the review - definitely appreciate the tips.

1. Classroom variant could use a toilet. You know, sellers are people with needs too.

Done.

2. Wardrobes in a shop look slightly out of place. Wardrobe is an opaque wooden cabinet more fitting for a house rather than a shop. Maybe replace them with locker or glass front cabinet?

Went with the glass cabinets.

3. weight field is useful only if you plan to make variants differ by rarity. If they all have the same chance to spawn, this field is redundant. It's not an error though.

Adjusted - I mean for the pool variant to be less common, but during testing I set the weights the same so I could more reliably spawn both.

4. Consider adding floor plants or vending machines.

Added a couple of both here and there.

5. Consider replacing wooden t_floor tiles around the pool with something more water-resistant.

Concrete.

6. Consider adding books on swimming in classroom variation.

Done - added swimming and some first aid books.

7. Consider adding windows in a classroom.

Added a few.

8. Consider adding air condition units.

Tweaked the roof more - added a skylight over the pool/classroom area, a couple of solar panels and an AC unit., and some standing tanks.

Updated the screenshots in the PR description.