Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new fine grinding quality to mortar and pestle + recipe updates #55518

Conversation

ElfLeaderMike
Copy link
Contributor

@ElfLeaderMike ElfLeaderMike commented Feb 20, 2022

Summary

None

Purpose of change

While low levels of grinding might be compatible with some recipes, there was no distinction for grinding things that would NOT be appropriate to grind with a tool such as the angle grinder (which has grinding 2 quality). Fine grinding allows us to differentiate the processes of grinding metals vs grinding fine powders like gunpowder and flour.

I also believe rocks and similar objects could have fine grinding as a quality, so there are tools which could use this new quality right now and in the future. Mortar and pestle would likely have a quality of 2 while rocks would be 1.

Describe the solution

Updated the json for several recipes/mortar and pestle.

Describe alternatives you've considered

Testing

All recipes have been tested in latest experimental.

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 6149a27 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

I noticed there are many recipes/tools involving grinding that could likely be updated for tool quality consistency. Tools such as the quern and food processor have no tool qualities right now, where I believe the ideal scenario would be for recipes to use as many tool qualities as possible, not the tools themselves.

I would eventually want to add fine grinding to the querns and food processor.

This PR attempts to focus on the mortar and pestle alone but there are more related changes that should be made.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 20, 2022
@ElfLeaderMike
Copy link
Contributor Author

I know this needs linting and I'll be fixing that shortly, I would love input on the fine grinding in the meantime.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 20, 2022
@Maleclypse Maleclypse added Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Feb 20, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 20, 2022
@ZhilkinSerg ZhilkinSerg merged commit fca5849 into CleverRaven:master Feb 21, 2022
@ElfLeaderMike ElfLeaderMike deleted the add-grinding-quality-to-mortar-and-pestle-+-recipe-updates branch February 21, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants