Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shaman attunement stuff #55509

Merged
merged 13 commits into from
Apr 22, 2022

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Feb 19, 2022

Summary

Mods "Improving shaman attunement"

Purpose of change

Yknow, there is nothing here atm

Describe the solution

  • Add spells
  • fix the bug with mound, that avoid using the AoE spell attack
  • add passive "mind reading" effect that shows monsters a certain distance away

Testing

Works fine, find them pretty useful

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 19, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • razor butterflys

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@GuardianDll GuardianDll marked this pull request as draft February 19, 2022 20:12
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2022
@GuardianDll GuardianDll changed the title Adding shaman attunement stuff Adding shaman attunement stuff (need help) Feb 19, 2022
@catdach
Copy link
Contributor

catdach commented Feb 19, 2022

I genuinely have no clue why monster don't use shambling_aoe

It might need a to have cooldown?
Also, might need to be above level 0?
so like, try making it:

"special_attacks": [
      { "type": "spell", "spell_data": { "id": "shambling_aoe", "min_level": 1 }, cooldown: 25 },

@GuardianDll
Copy link
Member Author

GuardianDll commented Feb 19, 2022

nope, both of leveling and cooldown do nothing, sadly
delete RANDOM_DAMAGE or RANDOM_AOE also do nothing
Upd: the reason - the game count spell as range attack, and not allow to use them in melee
due #55528 need to redone his attacks a bit

@Maleclypse Maleclypse added Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Effects / Skills / Stats Effects / Skills / Stats Monsters Monsters both friendly and unfriendly. labels Feb 20, 2022
@GuardianDll GuardianDll changed the title Adding shaman attunement stuff (need help) Adding shaman attunement stuff Feb 20, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 20, 2022
@GuardianDll GuardianDll marked this pull request as ready for review February 20, 2022 15:10
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 20, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A large, brightly colored butterfly with crystalline wings, fluttering incongruously through the air. This one seems to be patterned with orange runes, and its wings look razor-sharp.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 8, 2022
@KorGgenT
Copy link
Member

fix up the descriptions and the rest of it's good.

@github-actions github-actions bot added the Mods Issues related to mods or modding label Apr 19, 2022
@KorGgenT KorGgenT merged commit c7612e9 into CleverRaven:master Apr 22, 2022
@GuardianDll GuardianDll deleted the aaaand_another_magic_stuff branch May 13, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants