Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative black gunpowder recipe and update original recipe #55486

Conversation

ElfLeaderMike
Copy link
Contributor

@ElfLeaderMike ElfLeaderMike commented Feb 18, 2022

Summary

None

Purpose of change

Adds sulfur substitutes for black powder per feature request issue #55169

Describe the solution

Black gunpowder can now be made without sulfur. Reference
Mortar and pestle should be required for all recipes involving making gunpowder, in this PR I've changed both the original recipe and this one to use it, but there may be others that should have it.
The clean water + alcohol ratio is accurate based on the source and the final gunpowder product was reduced a little to reflect the new sulfurless process.
Most of the recipe properties are inherited from the sulfur recipe (which I believe to be okay since they're so similar)

Describe alternatives you've considered

Testing

Tested in latest experimental

New recipe:
image

Changes to reference recipe as well to include mortar and pestle:
image

Additional context

In making this new recipe, I've discovered that there's probably a good conversation around making a "mixing" quality as it seems that all of the "grinding"/"mixing" tools are manually added to the recipes that require it.

I also realized that gunpowder requires quite a bit of time to dry properly, and our current process is unrealistically fast. We likely need to create a gunpowder drying system, and change these recipes to create wet gunpowder.

added a sulfurless gunpowder recipe and updated the original sulfur using recipe to require a mortar and pestle
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 18, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 19, 2022
@Maleclypse Maleclypse added the Crafting / Construction / Recipes Includes: Uncrafting / Disassembling label Feb 20, 2022
@kevingranade kevingranade merged commit 51e44ef into CleverRaven:master Feb 20, 2022
@ElfLeaderMike ElfLeaderMike deleted the Adds-sulfur-substitutes-for-black-powder branch February 21, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants