Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix bug introduced in previous PR (ordering trapping resulted in foraging).
Describe the solution
Replaced "Foraging" with "Trapping" in three places.
Describe alternatives you've considered
Wait until the next rework PR is done.
Testing
Sent companion to trap small animals before the change and saw it resulted in foraging. Fixed the bug and tried again. Saw trapping actually resulted in trapping, including the returned items were actually dead animals (the beaver only temporarily so...).
Additional context
Both foraging and trapping results in double return entries on the bulletin board, and this PR does nothing to address that. My current theory is that it probably happens with tasks that can be ordered both from the base camp and from an expansion (in my case the kitchen), but it hasn't been verified. I consider that to be an annoyance that's better dealt with after the next rework of the faction camp mess, when the code might be slightly less incomprehensible.
I'd be grateful if this PR was reviewed without waiting for the RNGs to happen to generate a successful test run, as it's rather cumbersome to trigger new tests from this branch as it's used for the next rework step.