Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename foie gras to faux gras #55417

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

RabblerouserGT
Copy link
Contributor

Summary

None

Purpose of change

By the old description's own admission, it's technically not foie gras, which I feel opens this up for a possible rename. The old description also seemed somewhat bland.

Describe the solution

I'll be frank, I saw an opening for a pun a la the cannibal recipes and figured it'd be an easy first ever project to change the name from foie gras to faux gras. Description seemed bland, so I figured I'd change it as well.

Describe alternatives you've considered

Leaving as is. Or changing the systems of the game to differentiate meat by the animal they come from. Even more unlikely, adding force-feeding ducks while they're still alive to enlarge their liver. These options are beyond my capability.

Testing

Ran the game with the changes, even with Aftershock installed, which has a recipe override for foie gras, though I'm not sure how thorough my test was. This is my first attempt at a PR for this game, so I have no context of what's thorough or not.

Additional context

The id was left as is since I doubt the very specific methods of creating actual foie gras (force feeding a duck through a tube) will ever be implemented. This was a learning exercise for me in both the game systems and git, thus I won't be too upset if it's denied.

I'll be frank, I saw an opening for a pun and figured it'd be an easy first project. By the old description's own admission, this is technically not foie gras, which I feel opens this up for a possible rename. The description is changed as well since the original seemed somewhat bland. I left the id as is since I doubt the methods of creating realistic foie gras (force feeding ducks through tubes to make their livers enlarge) will ever be implemented.

This was a learning exercise for me in both the game systems and git, thus I won't be too upset if it's denied.
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 16, 2022
@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact and removed astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 16, 2022
@Night-Pryanik
Copy link

It might prove hard for translators to properly translate the pun.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 16, 2022
@RabblerouserGT
Copy link
Contributor Author

I never really thought about translators. I imagine they have a fit trying to translate the cannibal dishes. I won't be too bummed if it's a non-starter, though. I learned a lot from something so simple.

@Night-Pryanik
Copy link

It's okay to have word play or pun only in English, so your PR is okay too.

@kevingranade kevingranade merged commit b813bca into CleverRaven:master Feb 17, 2022
@RabblerouserGT RabblerouserGT deleted the faux_gras_rename branch February 17, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BasicBuildPassed This PR builds correctly, label assigned by github actions Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants