JSONify health text widget #55320
Merged
JSONify health text widget #55320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
astyled
dseguin
force-pushed
the
widget_migrate_health
branch
from
65c5eb8 to
f0e71a4
Compare
github-actions
bot
added
the
BasicBuildPassed
Maleclypse
added
the
Info / User Interface
14 tasks
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Mar 19, 2023
dseguin
pushed a commit
that referenced
this pull request
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Contributes to #55076.
Describe the solution
Convert the
health_textwidget_var to conditional clauses, and remove orphaned functions.Describe alternatives you've considered
Testing
Piggy-backing off the existing health widget test to check the new conditional clauses.
Also tested in-game:
Additional context