Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warmth On New Platemail #55269

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Feb 10, 2022

Summary

Bugfixes "New Platemail Now Has Warmth"

Purpose of change

The new plate armors didn't have warmth, even though it was defined in the JSON.

This seems like a huge change but is really tiny just the kind of thing Git struggles with interpreting

Describe the solution

A bunch of the new platemails had part of their islot_armor json entries in an "armor_data" object. This was pointless since the armors are armors so telling the game they have armor data only messed things up. This is why warmth wasn't being read. The game assumes all the armor data is in the armor_data object because "why wouldn't it be".

I removed the armor_data object entry for all the relevant armors. This is the standard for every other armor in game. It will now read armor data entries from the top level of the json object instead of the "armor_data" object.

Describe alternatives you've considered

Move all of their armor data into the armor_data object but that would cause people copying these in the future for their own overhauls to run into similar pitfalls.

Fix the underlying inconsistency breaking 12 things in the process 👨‍⚕️ and causing weirdness with non armor wearable items.

Testing

game loads

Now have armor and warmth
image

Additional context

so you can take a peak at whats been done @Drew4484

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 10, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 10, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 11, 2022
@kevingranade kevingranade merged commit 9506ebd into CleverRaven:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants