Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "New Platemail Now Has Warmth"
Purpose of change
The new plate armors didn't have warmth, even though it was defined in the JSON.
This seems like a huge change but is really tiny just the kind of thing Git struggles with interpreting
Describe the solution
A bunch of the new platemails had part of their islot_armor json entries in an "armor_data" object. This was pointless since the armors are armors so telling the game they have armor data only messed things up. This is why warmth wasn't being read. The game assumes all the armor data is in the armor_data object because "why wouldn't it be".
I removed the armor_data object entry for all the relevant armors. This is the standard for every other armor in game. It will now read armor data entries from the top level of the json object instead of the "armor_data" object.
Describe alternatives you've considered
Move all of their armor data into the armor_data object but that would cause people copying these in the future for their own overhauls to run into similar pitfalls.
Fix the underlying inconsistency breaking 12 things in the process 👨⚕️ and causing weirdness with non armor wearable items.
Testing
game loads
Now have armor and warmth
Additional context
so you can take a peak at whats been done @Drew4484