Print "You pushed your mount" only if it was really done #55242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
[C++]
github-actions
bot
added
json-styled
BrettDong
approved these changes
Feb 9, 2022
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Print 'You pushed your mount' only if it was really done."
Purpose of change
Previously if you tried to push your mount (e.g. a horse) into a terrain with
SHARPflag (e.g. a rose bush), the log will tell you thatYou pushed your mount, despite the horse stood in place.Describe the solution
Check if your mount will move to the location you pushed it to before printing the message.
Describe alternatives you've considered
None.
Testing
Placed my horse next to the rose bush. Look at my horse, my horse is amazing!
Tried to push it into the bush. My horse stood in place, the log correctly said it resisted to move.
Tried to push it to the empty place. The horse moved to that place, the log correctly said that I pushed my horse.
Additional context
None.