Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor character modifier / limb score tweaks #55239

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Feb 9, 2022

Summary

Balance "Adjust character modifiers"

Purpose of change

Assortment of minor limby tweaks related to crafting and other hand/arm stuff.
Fixes #54646

Describe the solution

  • Changed manipulation score calc to include the BP's of the relevant secondary_types in the appropriate bodypart_group (ie an arm that counts as a hand will be counted for the arm group and the hand group as well)

  • Changed the player display code to show negative limb scores as well

  • Added some debugmode messages to crafting, and show positive crafting speed multipliers in the crafting window

  • Removed wound scaling from balance score - a hurt torso doesn't really imbalance you, and piling on multiplicative penalties feels pretty dangerous from a balance standpoint

  • Moved melee/thrown speed modifier to lift from manipulation (encumbrance and wound-scaled, derived from arms)

  • Capped both melee_thrown_move_lift_mod and melee_thrown_move_balance_mod to 3x penalty each, and melee_stamina_cost_mod to 20x (mostly asspulls, but the speed of scaling wasn't very well communicated)

  • Referenced the name of the relevant limb score in the modifier descriptions to make the whole system a bit more readable

Describe alternatives you've considered

Break it up into two teeny PRs, but it's small enough imho.

Testing

Mutated WIP Insect Limbs (arm type, hand secondary type, negative manipulation/balance score) before the changes - no Manipulation score: or Balance score entry in the @ menu, melee to-hit malus showed up (balance score got calculated), crafting speed was 100% (manipulation calc was ignoring secondary types). After the changes scores show up in the menu, and manipulation malus is applied as expected. Progressed to Insect Arms (slight positive manipulation score), crafting speed readout showed craft rate instead of craftable.

Additional context

I'm pretty sure there could be some very smart system for crafting to decide (based on used skills, proficiencies and levels) if manipulation score should influence it or not , or in what capacity - plopping an egg into water isn't affected by manual dexterity as badly as tailoring, for instance. I'm not sure it will make it in the first round of Limb Stuff, unless somebody volunteers.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 9, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 9, 2022
@kevingranade kevingranade merged commit 8ef30be into CleverRaven:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hand encumbrance is too penalizing for melee
2 participants