Minor character modifier / limb score tweaks #55239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Adjust character modifiers"
Purpose of change
Assortment of minor limby tweaks related to crafting and other hand/arm stuff.
Fixes #54646
Describe the solution
Changed manipulation score calc to include the BP's of the relevant
secondary_types
in the appropriatebodypart_group
(ie an arm that counts as a hand will be counted for the arm group and the hand group as well)Changed the player display code to show negative limb scores as well
Added some debugmode messages to crafting, and show positive crafting speed multipliers in the crafting window
Removed wound scaling from balance score - a hurt torso doesn't really imbalance you, and piling on multiplicative penalties feels pretty dangerous from a balance standpoint
Moved melee/thrown speed modifier to
lift
frommanipulation
(encumbrance and wound-scaled, derived from arms)Capped both
melee_thrown_move_lift_mod
andmelee_thrown_move_balance_mod
to 3x penalty each, andmelee_stamina_cost_mod
to 20x (mostly asspulls, but the speed of scaling wasn't very well communicated)Referenced the name of the relevant limb score in the modifier descriptions to make the whole system a bit more readable
Describe alternatives you've considered
Break it up into two teeny PRs, but it's small enough imho.
Testing
Mutated WIP Insect Limbs (arm type, hand secondary type, negative manipulation/balance score) before the changes - no
Manipulation score:
orBalance score
entry in the @ menu, melee to-hit malus showed up (balance score got calculated), crafting speed was 100% (manipulation calc was ignoring secondary types). After the changes scores show up in the menu, and manipulation malus is applied as expected. Progressed to Insect Arms (slight positive manipulation score), crafting speed readout showed craft rate instead ofcraftable
.Additional context
I'm pretty sure there could be some very smart system for crafting to decide (based on used skills, proficiencies and levels) if manipulation score should influence it or not , or in what capacity - plopping an egg into water isn't affected by manual dexterity as badly as tailoring, for instance. I'm not sure it will make it in the first round of Limb Stuff, unless somebody volunteers.