Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Magiclysm] Adding new magic plants #55164

Merged
merged 50 commits into from
Aug 13, 2022
Merged

[Magiclysm] Adding new magic plants #55164

merged 50 commits into from
Aug 13, 2022

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Feb 6, 2022 •
edited
Loading

Summary

Mods "Adding new magic plants"

Purpose of change

Reopened #37103 with some changes

  • fix errors
  • make a rare map for some of them
  • make some special effects for plants
  • desing their using in alchemy
  • spawn plants in the map

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 6, 2022
@GuardianDll
Copy link
Member Author

btw am i need to add this herb names to spell checker ignore list?

@anothersimulacrum
Copy link
Member

I don't believe furniture and terrain can appear as plurals in-game, which is why you are seeing those problems.

@GuardianDll
Copy link
Member Author

GuardianDll commented Feb 6, 2022 •
edited
Loading

DAAAAAMN
its a furniture, when it must be COMESTIBLE
🤦
thank you, must be fixed now

@Maleclypse Maleclypse added Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact Mods: Magiclysm Anything to do with the Magiclysm mod labels Feb 6, 2022
@GuardianDll GuardianDll marked this pull request as ready for review February 6, 2022 19:44
@GuardianDll GuardianDll requested a review from KorGgenT as a code owner February 6, 2022 19:44
@GuardianDll GuardianDll marked this pull request as draft February 6, 2022 19:44
@GuardianDll
Copy link
Member Author

Accidentally turn off the draft mode, sorry

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • kampuch
  • kampuches

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@GuardianDll GuardianDll marked this pull request as ready for review May 23, 2022 11:45
@GuardianDll GuardianDll marked this pull request as draft May 23, 2022 14:52
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 23, 2022
@GuardianDll GuardianDll marked this pull request as ready for review May 23, 2022 18:10
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 23, 2022
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels May 23, 2022
@KorGgenT KorGgenT merged commit d095623 into CleverRaven:master Aug 13, 2022
@GuardianDll GuardianDll deleted the touch_the_grass branch August 14, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Night-Pryanik Night-Pryanik Night-Pryanik left review comments

@anothersimulacrum anothersimulacrum anothersimulacrum left review comments

@esotericist esotericist esotericist requested changes

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GuardianDll @anothersimulacrum @esotericist @Night-Pryanik @KorGgenT @Maleclypse @John-Candlebury