Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small and large space heater appliances #55140

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

Xenoamor
Copy link
Contributor

@Xenoamor Xenoamor commented Feb 5, 2022

Summary

Content "Adds small and large space heaters as static power grid appliances"

Purpose of change

To expand on #53647

Describe the solution

Simple JSON additions. Vehicle mounted heater recipes have been marked as reversible to make switching between mounted and appliance versions possible.

Describe alternatives you've considered

Testing

Tested when powered that they produce hot air

Additional context

We may want to change space heaters as they exist currently. Both the mounted and appliance versions come from battery operated devices which seems a bit odd. Perhaps a battery operated space heater should be a separate item?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 6, 2022
@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Appliance/Power Grid Anything to do with appliances and power grid labels Feb 6, 2022
@PatrikLundell
Copy link
Contributor

Do these space heaters actually work, i.e. do they heat up the room they are in (hot air is good, but only if the heat actually spread)? If you place one (or more) in a room with closed doors during winter, do they thaw frozen water in e.g. a bucket on the floor (or in mounted tanks)?

Fuel burning heating systems do not require electricity technically, so they should probably be introduced both as furniture and appliances, with the appliance versions being more advanced to e.g. regulate temperature and setting of it using electronics (again, it should be possible to device mechanical regulation based on physical properties, I think).

@Xenoamor
Copy link
Contributor Author

Xenoamor commented Feb 7, 2022

I'm not sure how heat works in the game but these work the same as they do in vehicles. It looks like they create a "hot air" effect on them with a fixed radius

@PatrikLundell
Copy link
Contributor

I'm unsure as well. I know vehicle coolers are said to be usable in Mi-go camps, and would guess heaters work the same, but that's not necessarily what's needed to heat an actual room. Vehicles tend to differ from buildings in that their interior is much more cramped, so limitations in the heat dispersion logic might not matter as much.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 10, 2022
@kevingranade kevingranade merged commit 454befe into CleverRaven:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants