Added check for being on ground for several cases of falling down #55128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
[C++]
github-actions
bot
added
json-styled
|
Glory be to our saviour, we will binge-drink of the floor in thy name! |
chuga-git
pushed a commit
to chuga-git/Cataclysm-DDA
that referenced
this pull request
Feb 7, 2022
…everRaven#55128) * Added check for being on ground for several cases of falling down * A few more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Added check for being on ground for several cases of falling down."
Purpose of change
Initially I planned only to fix #50689, but I noticed that there are several other cases where character is forced to fall down even when he is already on the ground (e.g. being prone), so I fixed them too.
Describe the solution
Replaced simple check for
downedeffect withis_on_groundcheck (or added it where appropriate) for several cases of falling down.Describe alternatives you've considered
None.
Testing
Got my character awfully drunk. Made it go prone. Waited to be knocked down - not happened.
Stood up. Waited to be knocked down, success.
Additional context
None.